User/jml/update fms2io tests #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated the makefile.am template to include test_fms2_io and test_atmosphere_io tests removed .bats references from test shell scripts and changed the program launchers to run_test changed name of input.nml to input_base.nml
wrongkindofdoctor
added
enhancement
wrongkindofdoctor
changed the title
removed unneeded test-specific fms library LDADD definitions from makefile
…in atmosphere_restart_file_test.inc
|
Per FMS meeting discussion on 2/13/2020, this is being pushed off to the next release, 2020.02. |
wrongkindofdoctor
requested review from
bensonr and
colingladueNOAA
as code owners
Sync with FMS master
|
I'm not sure why this is still failing. Make check passes externally, I have both tests set to "skip", but travis-ci is not registering the skip command in test_atmosphere_io.sh. |
|
OK, perhaps instead you want to remove input.nml from git. Then the copy
will work as intended...
…On Thu, Mar 26, 2020 at 3:46 PM uramirez8707 ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In test_fms/fms2_io/test_atmosphere_io.sh
<#280 (comment)>:
> @@ -1,2 +1,12 @@
#!/bin/sh
-bats ${srcdir}/test_fms/fms2_io/test_atmosphere_io.bats
+# This is part of the GFDL FMS package. This is a shell script to
+# execute tests in the test_fms/fms2_io directory.
+
+# Set common test settings.
+. ../test_common.sh
+
+# link to the input namelist
+cp ${srcdir}/test_fms/fms2_io/input_base.nml input.nml
@wrongkindofdoctor <https://github.com/wrongkindofdoctor> In travis make
distcheck fails because cp: cannot create regular file 'input.nml': File
exists
The test passes if you remove this line.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#280 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJIOMMH7PLHOEFQZDUICWNTRJPEMRANCNFSM4KP6BXBA>
.
|
added 3 commits
March 27, 2020 09:08
…from shell scripts added input.nml to directory since this file is just a dummy to test the namelist functionality removed input.nml from Makefile.am Cleanfiles line
…e.nml from test_fms/fms2_io/Makefile.am
|
Okay, this PR is FINALLY ready for review. Thanks, everyone! |
uramirez8707
previously approved these changes
Mar 27, 2020
colingladueNOAA
previously approved these changes
Mar 27, 2020
thomas-robinson
previously approved these changes
Mar 27, 2020
Yes. This fix is a stopgap to allow the test suite to run while I work on solving the issue(s) with the netcdf data type mismatches. |
…file in test_atmosphere_io.sh and test_fms2_io.sh
wrongkindofdoctor
dismissed stale reviews from thomas-robinson, colingladueNOAA, and uramirez8707
via
a9e4844
thomas-robinson
approved these changes
Apr 1, 2020
|
Can this be merged soon please? Currently your master branch is broken. This is something you should not tolerate. |
|
Thanks!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains updates to the fms2_io test suite in test_fms.
How Has This Been Tested?
Checklist:
make distcheckpasses